fix: improve Vertex AI redirect handling - #8685
Merged
Merged
Conversation
mattwittwer
force-pushed
the
mwittwer/vertex_ai_restricted_endpoint
branch
from
March 6, 2026 20:40
02f7d1c to
ffee72e
Compare
mattwittwer
changed the title
mattwittwer
changed the base branch from
main
to
spolisetty/tri-669-psirt-triton-inference-server-vertex-ai-integration-access
March 7, 2026 00:27
Base automatically changed from
spolisetty/tri-669-psirt-triton-inference-server-vertex-ai-integration-access
to
main
March 7, 2026 12:09
whoisj
previously approved these changes
Mar 9, 2026
whoisj
left a comment
whoisj
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Also looks near identical to you other PR, interesting.
mattwittwer
force-pushed
the
mwittwer/vertex_ai_restricted_endpoint
branch
from
March 11, 2026 23:00
ffee72e to
93df24c
Compare
yinggeh
approved these changes
Mar 11, 2026
Contributor
Author
|
Rebased this branch onto current |
mattwittwer
added a commit
that referenced
this pull request
Mar 11, 2026
(cherry picked from commit d8f1616)
This was referenced Mar 11, 2026
mc-nv
pushed a commit
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Restrict X-Vertex-Ai-Triton-Redirect to read-only routes and block repository control and shared-memory mutation requests from being tunneled through /predict.
Add test coverage for restricted vs allowed redirect targets, statistics access, and input-size enforcement
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
This PR is closely related to this Vertex AI endpoint improvement: #8680
Where should the reviewer start?
Test plan:
45551039
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)